-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Modify System.Net.Request to throw PNSE on Browser WASM #40274
Conversation
…ndWorkerTests.TestFinalization test
Tagging subscribers to this area: @safern, @ViktorHofer |
src/libraries/System.Net.Requests/src/System.Net.Requests.csproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modulo one suggestion.
src/libraries/System.Net.Requests/src/System.Net.Requests.csproj
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Requests/tests/System.Net.Requests.Tests.csproj
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Hello @marek-safar! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
…t#40274) * [wasm] Modify System.Net.Request to throw PNSE on Browser WASM * [wasm] Re-enable System.ComponentModel.EventBasedAsync.Tests.BackgroundWorkerTests.TestFinalization test * Make the CS0809 build warning depend on if PNSE assembly is going to be generated * Update src/libraries/System.Net.Requests/src/System.Net.Requests.csproj Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> * Remove redundant condition Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
This PR adds throwing PlatformNotSupportedException to
System.Net.Request
at assembly level.This also enables
System.ComponentModel.EventBasedAsync.Tests.BackgroundWorkerTests.TestFinalization
test which doesn't fail locally.